Release candidate v3.43.0 #360
Conversation
…vices, to ease last.fm integration
…up all queries (ex. sort artists by last write)
…Artist. But this is really best effort as it is way too long
…This made DSub behave badly. fixes #356
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -68,7 +87,7 @@ | |||
| LMS_LOG(DB, INFO) << "Creating connection pool on file " << dbPath.string(); | |||
|
|
|||
| auto connection{ std::make_unique<Connection>(dbPath.string()) }; | |||
| // connection->setProperty("show-queries", "true"); | |||
| // connection->setProperty("show-queries", "true"); | |||
Check notice
Code scanning / CodeQL
Commented-out code
| oss << " AND t_a_l.type IN ("; | ||
|
|
||
| bool first{ true }; | ||
| for ([[maybe_unused]] TrackArtistLinkType type : linkTypes) |
Check notice
Code scanning / CodeQL
Unused local variable
| oss << " AND t_a_l.type IN ("; | ||
|
|
||
| bool first{ true }; | ||
| for ([[maybe_unused]] TrackArtistLinkType type : linkTypes) |
Check notice
Code scanning / CodeQL
Unused local variable
| namespace | ||
| { | ||
| template <typename ResultType> | ||
| Wt::Dbo::Query<ResultType> createQuery(Session& session, std::string_view itemToSelect, const Artist::FindParameters& params) |
Check warning
Code scanning / CodeQL
Poorly documented large function
| || params.dateRange | ||
| || params.artist.isValid()) | ||
| template <typename ResultType> | ||
| Wt::Dbo::Query<ResultType> createQuery(Session& session, std::string_view itemToSelect, const Release::FindParameters& params) |
Check warning
Code scanning / CodeQL
Poorly documented large function
| namespace | ||
| { | ||
| template <typename ResultType> | ||
| Wt::Dbo::Query<ResultType> createQuery(Session& session, std::string_view itemToSelect, const Track::FindParameters& params) |
Check warning
Code scanning / CodeQL
Poorly documented large function
| addEntry(tracklistEntry); | ||
| } | ||
|
|
||
| void PlayQueue::addEntry(const Database::TrackListEntry::pointer& tracklistEntry) |
Check warning
Code scanning / CodeQL
Poorly documented large function
| }; | ||
| } | ||
|
|
||
| PlayQueue::PlayQueue() |
Check warning
Code scanning / CodeQL
Poorly documented large function
| refreshView(); | ||
| } | ||
|
|
||
| void Artist::refreshView() |
Check warning
Code scanning / CodeQL
Poorly documented large function
No description provided.